Ignore rule Scope should always be MultiWildcard
Upstream Quassel always uses the MultiWildcard
mode for matching Ignore Rule
Scope
. This is for backwards-compatibility with Quassel 0.12.x and lower, where the Regular expression
checkbox only applied to the rule itself, not the scope.
Quasseldroid should follow this. In IgnoreListManager.kt
, it should be changed so…
--- lib/src/main/java/de/kuschku/libquassel/quassel/syncables/IgnoreListManager.kt
+++ lib/src/main/java/de/kuschku/libquassel/quassel/syncables/IgnoreListManager.kt.new
@@ -189,8 +189,7 @@
),
ExpressionMatch(
scopeRule,
- if (isRegEx) ExpressionMatch.MatchMode.MatchRegEx
- else ExpressionMatch.MatchMode.MatchMultiWildcard,
+ ExpressionMatch.MatchMode.MatchMultiWildcard,
true
)
)
Regular expression
should continue to affect ignoreRule
itself, as before.
Thanks to #170 (closed) for bringing this issue to attention.