fix: correct signing configuration

gradle/convention/build.gradle.kts

@@ -32,6 +32,10 @@ gradlePlugin {
       id = "justjanne.kotlin"
       implementationClass = "KotlinConvention"
     }
+    register("signing") {
+      id = "justjanne.signing"
+      implementationClass = "SigningConvention"
+    }
   }
 }
 

gradle/convention/src/main/kotlin/AndroidApplicationConvention.kt

@@ -4,7 +4,6 @@ import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.kotlin.dsl.configure
 import util.git
-import util.properties
 import java.util.Locale
 
 class AndroidApplicationConvention : Plugin<Project> {
@@ -13,6 +12,7 @@ class AndroidApplicationConvention : Plugin<Project> {
       with(pluginManager) {
         apply("com.android.application")
         apply("justjanne.kotlin.android")
+        apply("justjanne.signing")
       }
 
       extensions.configure<ApplicationExtension> {
@@ -49,17 +49,6 @@ class AndroidApplicationConvention : Plugin<Project> {
           buildConfig = true
         }
 
-        signingConfigs {
-          SigningData.of(project.rootProject.properties("signing.properties"))?.let {
-            create("default") {
-              storeFile = file(it.storeFile)
-              storePassword = it.storePassword
-              keyAlias = it.keyAlias
-              keyPassword = it.keyPassword
-            }
-          }
-        }
-
         compileOptions {
           sourceCompatibility = JavaVersion.VERSION_11
           targetCompatibility = JavaVersion.VERSION_11

gradle/convention/src/main/kotlin/SigningConvention.kt

+import com.android.build.api.dsl.ApplicationExtension
+import org.gradle.api.Plugin
+import org.gradle.api.Project
+import org.gradle.kotlin.dsl.configure
+import util.properties
+
+class SigningConvention : Plugin<Project> {
+  override fun apply(target: Project) {
+    with(target) {
+      with(pluginManager) {
+        apply("com.android.application")
+        apply("justjanne.kotlin.android")
+      }
+
+      extensions.configure<ApplicationExtension> {
+        signingConfigs {
+          SigningData.of(rootProject.properties("signing.properties"))?.let {
+            create("default") {
+              storeFile = file(it.storeFile)
+              storePassword = it.storePassword
+              keyAlias = it.keyAlias
+              keyPassword = it.keyPassword
+            }
+          }
+        }
+      }
+    }
+  }
+}