Skip to content

GitLab

QuasselDroid-ng
QuasselDroid-ng
Open
Opened by Shane Synan@digitalcircuit
Report abuse New issue

Empty/invalid values should be rejected in several fields

Test case

Steps

  1. Connect to core
  2. Go to overflow menu → Core Settings

Network (servers)

  1. Add a new network
  2. Set Network Name
  3. Don't add any servers
  4. Press Save

This one may be more difficult to implement and can be set aside to a new issue if desired.

Quassel desktop actually even catches this if you delete all servers from a network after adding it:

Invalid Network Settings

The following problems need to be corrected before your changes can be applied:

  • All networks need at least one server defined

Network (name)

  1. Add a new network
  2. Don't set Network Name
  3. Add a dummy server
  4. Press Save

Network → Server

  1. Add a new server to an existing network
  2. Don't fill in Host
  3. Press Save

Identity

  1. Add a new identity
  2. Don't fill in Identity name
  3. Press Save

Chatlists

  1. Add a new chat list
  2. Don't fill in Name
  3. Press Save

Technically, this one is accepted by the Quassel core, but the desktop GUI requires specifying a name.

Ignore List → Ignore Rule (ignore rule)

  1. Add a new ignore rule
  2. Don't fill in Ignore Rule
  3. Press Save

Technically, this one is accepted by the Quassel core, but the desktop GUI requires specifying an ignore rule.

Ignore List → Ignore Rule (scope)

This one needs fixed in upstream Quassel, too. It can be ignored for now, or fixed.

  1. Add a new ignore rule
  2. Fill in Ignore Rule
  3. Set Scope to Network Scope
  4. Don't fill in Scope Rule
  5. Press Save

Technically, this one is accepted by the Quassel core, and the desktop GUI does not require specifying an ignore rule scope, but it probably should.

Aliases → Alias (name)

  1. Add a new alias
  2. Don't fill in Name
  3. Press Save

Bonus: this logs a crash report in Quasseldroid due to a non-null value set to null. See the crash issue for the specifics.

Aliases → Alias (expansion)

  1. Add a new alias
  2. Don't fill in Expansion
  3. Press Save

Bonus: this logs a crash report in Quasseldroid due to a non-null value set to null. See the crash issue for the specifics.

Expected

Quasseldroid rejects the empty fields in the above cases.

Actual

Quasseldroid accepts the empty fields in the above cases, highlighting with red/whatever method Android uses to indicate a field is required.

Additional

The Android approaches appears to be using setHint and setError.

Edited by Shane Synan
To upload designs, you'll need to enable LFS. More information